Presigned URL の発行時のエラー解消#1564
Open
Cen4Soca wants to merge 18 commits into
Open
Conversation
The UI's LinkRenderer detects S3 URLs in Markdown links and converts them to presigned URLs for download. Without Markdown link format, S3 URLs for non-image files (e.g. .pptx) are rendered as plain text and cannot be downloaded.
- Revert cdk.json formatting noise and createGenericAgentCoreRuntime back to false (default) - Add agentCoreCodeInterpreterEnabled to correct location (default false) - Add agentCoreCodeInterpreterEnabled to English DEPLOY_OPTION.md - Remove sdpm-specific example from Japanese DEPLOY_OPTION.md - Update CDK test snapshots
Adds a write_file tool that allows agents to create and append to files under /tmp/ws without requiring Code Interpreter. This enables MCP tools that expect file paths (e.g. generate_pptx with slides_json_path) to work without the Code Interpreter sandbox isolation issue. Path traversal is prevented by requiring all paths to be under WORKSPACE_DIR.
Allows agents to fetch text content from URLs. HTML is automatically stripped of scripts/styles/tags for readability. Useful for reading documentation, reference materials, or API responses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
素敵なOSSをありがとうございます。日々、活用させていただいております。
PRの発行は初めてのため、不備があればご指摘頂けますと幸いです。
GenU と SDPM (Spec-Driven Presentation Maker) を組み合わせて利用することを想定しています。
当PRの内容は大きく下記２点になります。
PR #1526 (comment) を個人のリポジトリにフォークして、コンフリクト解消した上で動作確認したところ、Agent Builder で SDPM を用いてファイル出力した際に Presigned URL の発行でエラーとなりました。
upload_file_to_s3_and_retrieve_s3_url で取得した S3 URL から Presigned URL を生成する際、Lambda 関数自体がそのS3バケットへのアクセス権限を必要としますが、現在の実装では API Lambda は Agent Core のS3バケットへのアクセス権限を持っておらず、Agent CoreのS3バケットに対して Presigned URL を生成できません。"api.ts" を変更して Lambda に Agent Core S3 バケット (additionalS3Buckets) への read 権限を追加しました。
Summary
Checklist
npm run cdk:testand if there are snapshot differences, executenpm run cdk:test:update-snapshotto update snapshotsRelated PR
#1526 (comment)